You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please complete all fields. PRs will not be merged if any fields are incomplete. Be respectful, and keep in mind that it may take some time for your PR to be reviewed.
Bear in mind refactors are up to the developers and not it's contributors after all we are the ones giving support when needed. if they are big changes I suggest you to release it under your name instead.
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Motive for This Pull Request
This PR is opened to get feedback before the work is finished.
Provide a brief explanation of why these changes are being proposed and what they aim to achieve.
This PR adds a raycast module and a logger module to vorp_lib.
Explain the necessity of these changes and how they will impact the framework or its users.
These changes add reusable utility modules for developers. raycast helps with client-side raycasts and logger provides cleaner logs with resource name, time, and log level.
Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests. Also, list any relevant details for your test configuration.
Tested with latest vorp scripts
Tested with latest artifacts
Notes if any
This PR is still in progress and is not ready to merge yet. It is opened now to receive feedback.
I see this as draft, so make sure you are using methods like the rest of the modules please Logger:Warn()Logger:Error() etc like you did before.
Right now you doing this as functions in a table. we want to keep the code as consistent as possible just like the rest of the modules. or at least try. Methods are just nicer :) and I have planned features for the logger if it gets merged.
I see this as draft, so make sure you are using methods like the rest of the modules please
Logger:Warn()Logger:Error() etc like you did before.
Right now you doing this as functions in a table. we want to keep the code as consistent as possible just like the rest of the modules. or at least try. Methods are just nicer :) and I have planned features for the logger if it gets merged.
Thanks for the review. I’ll apply the changes !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request template
Important
Please complete all fields. PRs will not be merged if any fields are incomplete. Be respectful, and keep in mind that it may take some time for your PR to be reviewed.
Bear in mind refactors are up to the developers and not it's contributors after all we are the ones giving support when needed. if they are big changes I suggest you to release it under your name instead.
Type of change
Motive for This Pull Request
This PR is opened to get feedback before the work is finished.
Provide a brief explanation of why these changes are being proposed and what they aim to achieve.
This PR adds a
raycastmodule and aloggermodule tovorp_lib.Explain the necessity of these changes and how they will impact the framework or its users.
These changes add reusable utility modules for developers.
raycasthelps with client-side raycasts andloggerprovides cleaner logs with resource name, time, and log level.Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests. Also, list any relevant details for your test configuration.
Notes if any
This PR is still in progress and is not ready to merge yet. It is opened now to receive feedback.